docs: R108 no longer asks for territorial waters in the mask #188

Merged

art merged 1 commit from fix-r108-wording into main

2026-08-20 10:39:06 +00:00

art-bot commented

2026-08-20 10:25:45 +00:00

Collaborator

Small docs-only correction — merge whenever, nothing depends on it.

R108 still reads:

Check whether the border source already includes territorial waters. Poland's PRG border does, so no buffer is needed; Iceland uses a 25 km buffered convex hull because its regional polygons do not.

That was right while the mask carved the Natural Earth background. Since #185 it is not: conf/world.yaml carves with Natural Earth's own admin-0 polygons and reads only the country code from map_country_mask_0, never its geometry (R144).

As written, the rule points the next country straight at the trap Greece spent two rounds in — extend the mask over the water so Natural Earth stops drawing land in the gulfs. That does not work, because the error is in the other operand. The add-country skill (#178) and docs/country-gr.md (#183) were both updated to say exactly that, and both cite R108 — which still says the opposite.

My miss: I pulled this rewrite out of #183 so it would not collide with #185's R144–R146, intending to move it onto #185, and never did.

R108 now says the mask is the country's own outline, that nothing depends on its shape, and that the carve's correctness lives in R144/R145/R146 — with R146 named as the one place the world config still reads mask geometry, as a check rather than an input.

Small docs-only correction — merge whenever, nothing depends on it. R108 still reads: > Check whether the border source already includes territorial waters. Poland's PRG border does, so no buffer is needed; Iceland uses a 25 km buffered convex hull because its regional polygons do not. That was right while the mask carved the Natural Earth background. Since #185 it is not: `conf/world.yaml` carves with Natural Earth's own admin-0 polygons and reads only the `country` code from `map_country_mask_0`, never its geometry (R144). As written, the rule points the next country **straight at the trap Greece spent two rounds in** — extend the mask over the water so Natural Earth stops drawing land in the gulfs. That does not work, because the error is in the other operand. The `add-country` skill (#178) and `docs/country-gr.md` (#183) were both updated to say exactly that, and both cite R108 — which still says the opposite. My miss: I pulled this rewrite out of #183 so it would not collide with #185's R144–R146, intending to move it onto #185, and never did. R108 now says the mask is the country's own outline, that nothing depends on its shape, and that the carve's correctness lives in R144/R145/R146 — with R146 named as the one place the world config still reads mask geometry, as a check rather than an input.

art-bot added 1 commit

2026-08-20 10:25:45 +00:00

docs: R108 no longer asks for territorial waters in the mask 27e4fd430e

R108 still told the next country to check whether its border source includes
territorial waters, and offered Iceland's buffered convex hull as the fallback if
it does not. That was correct while the mask carved the Natural Earth background.
It has not been true since #185: conf/world.yaml carves with Natural Earth's own
admin-0 polygons and reads only the country code from map_country_mask_0.

So the rule as written pointed straight at the trap Greece spent two rounds in —
extend the mask over the water to stop Natural Earth drawing land in the gulfs,
which does not work because the error is in the other operand. The add-country
skill and docs/country-gr.md were both updated to say so; this requirement, which
is what they cite, was missed. I meant to move this rewrite onto #185 when I took
it out of #183 and never did.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q8HxnPejASTBhLaSxJKqBA