importer: finish what #185 missed — the ne_10m rename in Go, and R145's log format #187

Merged

art merged 1 commit from fix-ne-staging-rename into main

2026-08-20 10:08:21 +00:00

art-bot commented

2026-08-20 10:04:36 +00:00

Collaborator

main is currently red — merge this first.

#185 renamed the Natural Earth staging tables (ne_110m_land → ne_10m_land, and the new ne_10m_admin_0) when it moved the world background to 1:10m, and missed three Go references. dag_test.go asserts by name that the shared staging from conf/common.yaml merged into the plan:

--- FAIL: TestFullPlanRealConfigs/conf/is
    dag_test.go:79: plan missing s:ne_110m_land (include merge failed?)
--- FAIL: TestFullPlanRealConfigs/conf/se
--- FAIL: TestFullPlanRealConfigs/conf/pl

No behaviour change: one assertion string and two comments. go build, go vet, go test ./... green with it.

How it got through

The rename was mechanical, so I scoped the search-and-replace to conf/, Makefile and docs/ — and then verified the change against the live database, the acceptance suite and rendered screenshots without re-running go test. The database was the thing I had been burned on earlier in this work, so it is the thing I checked. A rename crosses languages, and the Go suite is where that shows up; make acceptance does not run it.

**main is currently red** — merge this first. #185 renamed the Natural Earth staging tables (`ne_110m_land` → `ne_10m_land`, and the new `ne_10m_admin_0`) when it moved the world background to 1:10m, and missed three Go references. `dag_test.go` asserts *by name* that the shared staging from `conf/common.yaml` merged into the plan: ``` --- FAIL: TestFullPlanRealConfigs/conf/is dag_test.go:79: plan missing s:ne_110m_land (include merge failed?) --- FAIL: TestFullPlanRealConfigs/conf/se --- FAIL: TestFullPlanRealConfigs/conf/pl ``` No behaviour change: one assertion string and two comments. `go build`, `go vet`, `go test ./...` green with it. ## How it got through The rename was mechanical, so I scoped the search-and-replace to `conf/`, `Makefile` and `docs/` — and then verified the change against the live database, the acceptance suite and rendered screenshots without re-running `go test`. The database was the thing I had been burned on earlier in this work, so it is the thing I checked. A rename crosses languages, and the Go suite is where that shows up; `make acceptance` does not run it.

art-bot added 1 commit

2026-08-20 10:04:37 +00:00

importer: finish the ne_110m -> ne_10m rename in the Go tests and comments a061dbe574

#185 renamed the Natural Earth staging tables when it moved the world background
to 1:10m, and missed three Go references. dag_test.go asserts by name that the
shared staging from conf/common.yaml merged into the plan, so it failed for
conf/is, conf/se and conf/pl the moment the name changed — main has been red since
that merge.

My fault twice over: the rename was mechanical and I did it with a search and
replace scoped to conf/, Makefile and docs/, and then verified the change against
the database and the rendered map without re-running go test. The database was the
thing I had been burned on, so it is the thing I checked. A rename crosses
languages; the test suite is where that shows.

No behaviour change — two comments and one assertion string.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q8HxnPejASTBhLaSxJKqBA

art merged commit a061dbe574 into main

2026-08-20 10:08:21 +00:00

art deleted branch fix-ne-staging-rename

2026-08-20 10:08:21 +00:00

art-bot changed title from ~~importer: finish the ne_110m -> ne_10m rename in the Go tests (main is red)~~ to importer: finish what #185 missed — the ne_10m rename in Go, and R145's log format

2026-08-20 10:09:45 +00:00