No reviewers
Labels
No labels
blocked
claude-wip
map-report
map:is
map:se
needs-review
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
art/ismap!100
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "issue-83-cover-vocabulary"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Refs #83 — pieces 2 and 3 of the cover-vocabulary issue. This PR deliberately carries
no closing keyword: the issue's own scope says it must not be closed without piece 1
(Sweden's wetland, tracked as #14), so #83 stays open until #14 lands.
#83: cover vocabulary — Poland's wetland absence is source truth, and the grassland boundary is recorded
Piece 1 (Sweden's missing wetland) is #14, already tracked as the dependency of this
issue — not part of this work; the configs, docs and DB were left untouched on that
front except for recording the exemption below.
Piece 2 — Poland's missing wetland: the catalogue-cited negative answer
The R6 check is done, and the answer is negative. GUGiK's published BDOT10k delivery
(
opendata.geoportal.gov.pl/bdot10k/schemat2021/GPKG/<ww>/<teryt>_GPKG.zip) is theprovider's complete class catalogue, and it contains no marsh/bog class at all:
the county that holds most of the Biebrza marshes, Poland's largest wetland),
carry nothing wetland-shaped in the PT group or in any other group;
rodzajdomains are exhaustive country-wide(from the loaded staging tables) with no bog value either — PTGN ("nieużytki", the
traditional home of Polish bogs) holds only
teren piaszczysty lub żwirowy(5 322 rows),
pozostałe grunty nieużytkowane(2 029),teren kamienisty(676),piarg, usypisko lub rumowisko skalne(361).All twelve PT classes are already fetched — the
pt-sw-sk-oikmmarker names the classset it covers, so there is nothing to widen the fetch list with, and R9's marker rule is
not exercised. Poland's z3 cover has no
wetlandby source truth, not fetch gap;the written exemption now lives in
docs/country-poland.mdand next to the rollups inconf/common.yaml.One measurement that makes the negative answer concrete: where BDOT10k does survey the
marsh ground, it classifies it as grass — over the Biebrza valley bbox (22.3–22.9 E,
53.2–53.7 N) the z13 table's 3857 geometry is 2 974 km² of
pasture, the valley'ssingle largest class. Poland's wetland is hiding inside
pastureexactly the waySweden's hides inside
natural_grassland.Piece 3 — the natural_grassland / pasture / moor boundary: the review is done and recorded
R44's check, four countries side by side, now written next to the
landcoverenum inconf/common.yaml:Decision (recorded in conf/common.yaml): the boundary is drawn at the CORINE
definitions (231 = agricultural grass, 321 = semi-natural low-productivity grass,
322 = low closed shrub cover), and the check passes — every country that can
distinguish the concepts does, and each coarse source lands on the class its mixture
is closest to. The visible cross-country mismatch (Sweden's meadows render as
natural_grasslandwhere Poland's equivalent ground renders aspasture) is agranularity artifact of the sources, not a concept divergence: neither survey
separates managed from semi-natural grass, so both are mapped to the aggregate-
dominant class per R137, and each judgement was already written next to the query that
makes it (semap.yaml / plmap.yaml). No mapping changes; this is the record the issue
asked for.
The z3 written exemptions (R22), now all recorded
Acceptance is "every country's z3 cover produces exactly the tier's defined vocabulary
or has a written exemption". Verified against the live DB:
artificial(791 km² at z5) absorbs at z4,agricultural(4 727 km² at z4) at z3 — whole-class totals under the 16 px² floor (1 532 / 6 128 km²), the absorption knob doing its job on a country whose arable land is 0.1% of its areamarkhas no wetland; the mires live in thesankmarkoverlay, whose carve-out is #14 — the dependency this issue waits forVerification
importerTestRealConfigsValidatepasses over all five configs (the edits toconf/common.yamlare comment-only, but the configs are re-validated as the looprequires);
make buildandmapsrvgo test ./...pass;coverqueries above are run against the live DB, not assumed;downloaded to /tmp for inspection only — nothing was re-fetched into
data/and noreimport was needed, since this is a review-and-record change, not a data change).
Left undone / uncertain
enum changed). If a future BDOT10k delivery adds a wetland class, the marker
(
pt-sw-sk-oikm) names the set and would need a new name — that is R9's rule, notedhere for the record.
ec597ff279tob63fd489c1