art/ismap
1
0
Fork 0
Code Issues 18 Pull requests 1 Projects Releases Packages Wiki Activity Actions

missing iceland landcover #46

New issue
Closed
opened 2026-08-03 18:12:49 +00:00 by map-issues-bot · 5 comments
map-issues-bot commented 2026-08-03 18:12:49 +00:00
Collaborator
Copy link

something went wrong with the northern parts of iceland, everything is cut off past 66.5 north.

Location: z11 / 66.47022 / -16.42047
Feature: cover — country=is, cover_class=sport_leisure
Area: circle r=4560 m @ 66.55541, -18.02804

{
 "features": [
  {
   "geometry": {
    "type": "Polygon",
    "coordinates": [
     [
      [
       -21.242516040802002,
       64.1492512987814
      ],
      [
       -21.243621110916138,
       64.14872734922474
      ],
      [
       -21.244018077850342,
       64.14853554378942
      ],
      [
       -21.247612237930298,
       64.14703848022225
      ],
      [
       -21.24852418899536,
       64.14704783712025
      ],
      [
       -21.25079870223999,
       64.14774959548245
      ],
      [
       -21.25107765197754,
       64.14798818928483
      ],
      [
       -21.250970363616943,
       64.14842326682214
      ],
      [
       -21.249961853027344,
       64.1492512987814
      ],
      [
       -21.242516040802002,
       64.1492512987814
      ]
     ]
    ]
   },
   "properties": {
    "_layer": "cover_urban_vegetation",
    "_sourceLayer": "cover",
    "country": "is",
    "cover_class": "sport_leisure"
   },
   "type": "Feature"
  },
  {
   "geometry": {
    "type": "Polygon",
    "coordinates": [
     [
      [
       -17.925088484476564,
       66.55540971137734
      ],
      [
       -17.925584243227156,
       66.55942469654549
      ],
      [
       -17.927066745051146,
       66.56340101521165
      ],
      [
       -17.929521712645556,
       66.56730037325342
      ],
      [
       -17.93292550333043,
       66.5710852177212
      ],
      [
       -17.937245336740773,
       66.57471909849379
      ],
      [
       -17.942439610519376,
       66.57816701931287
      ],
      [
       -17.948458300970277,
       66.58139577481612
      ],
      [
       -17.955243444814283,
       66.58437427032302
      ],
      [
       -17.962729697407035,
       66.58707382129364
      ],
      [
       -17.970844962043667,
       66.58946842957641
      ],
      [
       -17.979511084289474,
       66.59153503378452
      ],
      [
       -17.988644604649842,
       66.59325373138975
      ],
      [
       -17.998157562330814,
       66.59460797039462
      ],
      [
       -18.007958342349603,
       66.59558470873719
      ],
      [
       -18.017952557836985,
       66.59617453989331
      ],
      [
       -18.02804395903442,
       66.5963717834665
      ],
      [
       -18.038135360231855,
       66.59617453989331
      ],
      [
       -18.048129575719237,
       66.59558470873719
      ],
      [
       -18.057930355738026,
       66.59460797039462
      ],
      [
       -18.067443313419,
       66.59325373138975
      ],
      [
       -18.076576833779367,
       66.59153503378452
      ],
      [
       -18.085242956025173,
       66.58946842957641
      ],
      [
       -18.093358220661806,
       66.58707382129364
      ],
      [
       -18.100844473254558,
       66.58437427032302
      ],
      [
       -18.107629617098564,
       66.58139577481612
      ],
      [
       -18.113648307549465,
       66.57816701931287
      ],
      [
       -18.118842581328067,
       66.57471909849379
      ],
      [
       -18.12316241473841,
       66.5710852177212
      ],
      [
       -18.126566205423284,
       66.56730037325342
      ],
      [
       -18.129021173017694,
       66.56340101521165
      ],
      [
       -18.130503674841684,
       66.55942469654549
      ],
      [
       -18.130999433592276,
       66.55540971137734
      ],
      [
       -18.130503674841684,
       66.55139472620918
      ],
      [
       -18.129021173017694,
       66.54741840754302
      ],
      [
       -18.126566205423284,
       66.54351904950126
      ],
      [
       -18.12316241473841,
       66.53973420503347
      ],
      [
       -18.118842581328067,
       66.53610032426089
      ],
      [
       -18.113648307549465,
       66.5326524034418
      ],
      [
       -18.107629617098564,
       66.52942364793856
      ],
      [
       -18.100844473254558,
       66.52644515243165
      ],
      [
       -18.093358220661806,
       66.52374560146103
      ],
      [
       -18.085242956025173,
       66.52135099317826
      ],
      [
       -18.076576833779367,
       66.51928438897015
      ],
      [
       -18.067443313419,
       66.51756569136492
      ],
      [
       -18.057930355738026,
       66.51621145236005
      ],
      [
       -18.048129575719237,
       66.51523471401748
      ],
      [
       -18.038135360231855,
       66.51464488286136
      ],
      [
       -18.02804395903442,
       66.51444763928818
      ],
      [
       -18.017952557836985,
       66.51464488286136
      ],
      [
       -18.007958342349603,
       66.51523471401748
      ],
      [
       -17.998157562330814,
       66.51621145236005
      ],
      [
       -17.988644604649842,
       66.51756569136492
      ],
      [
       -17.979511084289474,
       66.51928438897015
      ],
      [
       -17.970844962043667,
       66.52135099317826
      ],
      [
       -17.962729697407035,
       66.52374560146103
      ],
      [
       -17.955243444814283,
       66.52644515243165
      ],
      [
       -17.948458300970277,
       66.52942364793856
      ],
      [
       -17.942439610519376,
       66.5326524034418
      ],
      [
       -17.937245336740773,
       66.53610032426089
      ],
      [
       -17.93292550333043,
       66.53973420503347
      ],
      [
       -17.929521712645556,
       66.54351904950126
      ],
      [
       -17.927066745051146,
       66.54741840754302
      ],
      [
       -17.925584243227156,
       66.55139472620918
      ],
      [
       -17.925088484476564,
       66.55540971137734
      ]
     ]
    ]
   },
   "properties": {
    "_kind": "selection-circle",
    "_radius_m": 4560
   },
   "type": "Feature"
  }
 ],
 "properties": {
  "lat": 66.470221,
  "lng": -16.420475,
  "map": "se",
  "zoom": 10.63
 },
 "type": "FeatureCollection"
}
something went wrong with the northern parts of iceland, everything is cut off past 66.5 north. --- **Location:** [z11 / 66.47022 / -16.42047](https://experiments.blahonga.org/?map=se#10.63/66.4702/-16.4205) **Feature:** `cover` — country=is, cover_class=sport_leisure **Area:** circle r=4560 m @ 66.55541, -18.02804 ```map-report { "features": [ { "geometry": { "type": "Polygon", "coordinates": [ [ [ -21.242516040802002, 64.1492512987814 ], [ -21.243621110916138, 64.14872734922474 ], [ -21.244018077850342, 64.14853554378942 ], [ -21.247612237930298, 64.14703848022225 ], [ -21.24852418899536, 64.14704783712025 ], [ -21.25079870223999, 64.14774959548245 ], [ -21.25107765197754, 64.14798818928483 ], [ -21.250970363616943, 64.14842326682214 ], [ -21.249961853027344, 64.1492512987814 ], [ -21.242516040802002, 64.1492512987814 ] ] ] }, "properties": { "_layer": "cover_urban_vegetation", "_sourceLayer": "cover", "country": "is", "cover_class": "sport_leisure" }, "type": "Feature" }, { "geometry": { "type": "Polygon", "coordinates": [ [ [ -17.925088484476564, 66.55540971137734 ], [ -17.925584243227156, 66.55942469654549 ], [ -17.927066745051146, 66.56340101521165 ], [ -17.929521712645556, 66.56730037325342 ], [ -17.93292550333043, 66.5710852177212 ], [ -17.937245336740773, 66.57471909849379 ], [ -17.942439610519376, 66.57816701931287 ], [ -17.948458300970277, 66.58139577481612 ], [ -17.955243444814283, 66.58437427032302 ], [ -17.962729697407035, 66.58707382129364 ], [ -17.970844962043667, 66.58946842957641 ], [ -17.979511084289474, 66.59153503378452 ], [ -17.988644604649842, 66.59325373138975 ], [ -17.998157562330814, 66.59460797039462 ], [ -18.007958342349603, 66.59558470873719 ], [ -18.017952557836985, 66.59617453989331 ], [ -18.02804395903442, 66.5963717834665 ], [ -18.038135360231855, 66.59617453989331 ], [ -18.048129575719237, 66.59558470873719 ], [ -18.057930355738026, 66.59460797039462 ], [ -18.067443313419, 66.59325373138975 ], [ -18.076576833779367, 66.59153503378452 ], [ -18.085242956025173, 66.58946842957641 ], [ -18.093358220661806, 66.58707382129364 ], [ -18.100844473254558, 66.58437427032302 ], [ -18.107629617098564, 66.58139577481612 ], [ -18.113648307549465, 66.57816701931287 ], [ -18.118842581328067, 66.57471909849379 ], [ -18.12316241473841, 66.5710852177212 ], [ -18.126566205423284, 66.56730037325342 ], [ -18.129021173017694, 66.56340101521165 ], [ -18.130503674841684, 66.55942469654549 ], [ -18.130999433592276, 66.55540971137734 ], [ -18.130503674841684, 66.55139472620918 ], [ -18.129021173017694, 66.54741840754302 ], [ -18.126566205423284, 66.54351904950126 ], [ -18.12316241473841, 66.53973420503347 ], [ -18.118842581328067, 66.53610032426089 ], [ -18.113648307549465, 66.5326524034418 ], [ -18.107629617098564, 66.52942364793856 ], [ -18.100844473254558, 66.52644515243165 ], [ -18.093358220661806, 66.52374560146103 ], [ -18.085242956025173, 66.52135099317826 ], [ -18.076576833779367, 66.51928438897015 ], [ -18.067443313419, 66.51756569136492 ], [ -18.057930355738026, 66.51621145236005 ], [ -18.048129575719237, 66.51523471401748 ], [ -18.038135360231855, 66.51464488286136 ], [ -18.02804395903442, 66.51444763928818 ], [ -18.017952557836985, 66.51464488286136 ], [ -18.007958342349603, 66.51523471401748 ], [ -17.998157562330814, 66.51621145236005 ], [ -17.988644604649842, 66.51756569136492 ], [ -17.979511084289474, 66.51928438897015 ], [ -17.970844962043667, 66.52135099317826 ], [ -17.962729697407035, 66.52374560146103 ], [ -17.955243444814283, 66.52644515243165 ], [ -17.948458300970277, 66.52942364793856 ], [ -17.942439610519376, 66.5326524034418 ], [ -17.937245336740773, 66.53610032426089 ], [ -17.93292550333043, 66.53973420503347 ], [ -17.929521712645556, 66.54351904950126 ], [ -17.927066745051146, 66.54741840754302 ], [ -17.925584243227156, 66.55139472620918 ], [ -17.925088484476564, 66.55540971137734 ] ] ] }, "properties": { "_kind": "selection-circle", "_radius_m": 4560 }, "type": "Feature" } ], "properties": { "lat": 66.470221, "lng": -16.420475, "map": "se", "zoom": 10.63 }, "type": "FeatureCollection" } ```
map-issues-bot commented 2026-08-03 18:13:01 +00:00
Author
Collaborator
Copy link

Location: z9 / 66.42155 / -16.70454
Area: circle r=23959 m @ 66.52587, -16.11064

{
 "features": [
  {
   "geometry": {
    "type": "Polygon",
    "coordinates": [
     [
      [
       -15.570315459759863,
       66.52587023554591
      ],
      [
       -15.572917287580388,
       66.54696662126665
      ],
      [
       -15.580697714017745,
       66.56785983726044
      ],
      [
       -15.593581809312129,
       66.58834867043586
      ],
      [
       -15.611445492582693,
       66.60823580212912
      ],
      [
       -15.63411672679426,
       66.62732970839056
      ],
      [
       -15.661377175568012,
       66.64544650446514
      ],
      [
       -15.692964305880183,
       66.66241171570299
      ],
      [
       -15.728573916398584,
       66.67806195784574
      ],
      [
       -15.76786306710773,
       66.69224651050631
      ],
      [
       -15.810453382008658,
       66.70482876868847
      ],
      [
       -15.855934693086636,
       66.71568755836779
      ],
      [
       -15.903868990453372,
       66.72471830346362
      ],
      [
       -15.953794640621668,
       66.731834032964
      ],
      [
       -16.00523083228827,
       66.73696621850398
      ],
      [
       -16.057682206809545,
       66.74006543433127
      ],
      [
       -16.110643628776018,
       66.74110183330326
      ],
      [
       -16.16360505074249,
       66.74006543433127
      ],
      [
       -16.216056425263766,
       66.73696621850398
      ],
      [
       -16.267492616930365,
       66.731834032964
      ],
      [
       -16.317418267098663,
       66.72471830346362
      ],
      [
       -16.3653525644654,
       66.71568755836779
      ],
      [
       -16.41083387554338,
       66.70482876868847
      ],
      [
       -16.453424190444306,
       66.69224651050631
      ],
      [
       -16.49271334115345,
       66.67806195784574
      ],
      [
       -16.528322951671854,
       66.66241171570299
      ],
      [
       -16.55991008198402,
       66.64544650446514
      ],
      [
       -16.587170530757774,
       66.62732970839056
      ],
      [
       -16.609841764969342,
       66.60823580212912
      ],
      [
       -16.627705448239904,
       66.58834867043586
      ],
      [
       -16.64058954353429,
       66.56785983726044
      ],
      [
       -16.648369969971647,
       66.54696662126665
      ],
      [
       -16.65097179779217,
       66.52587023554591
      ],
      [
       -16.648369969971647,
       66.50477384982517
      ],
      [
       -16.64058954353429,
       66.48388063383138
      ],
      [
       -16.627705448239904,
       66.46339180065596
      ],
      [
       -16.609841764969342,
       66.4435046689627
      ],
      [
       -16.587170530757774,
       66.42441076270126
      ],
      [
       -16.559910081984025,
       66.40629396662668
      ],
      [
       -16.528322951671854,
       66.38932875538883
      ],
      [
       -16.49271334115345,
       66.37367851324608
      ],
      [
       -16.453424190444306,
       66.35949396058551
      ],
      [
       -16.41083387554338,
       66.34691170240335
      ],
      [
       -16.3653525644654,
       66.33605291272403
      ],
      [
       -16.317418267098663,
       66.3270221676282
      ],
      [
       -16.267492616930365,
       66.31990643812782
      ],
      [
       -16.216056425263766,
       66.31477425258784
      ],
      [
       -16.16360505074249,
       66.31167503676055
      ],
      [
       -16.110643628776018,
       66.31063863778856
      ],
      [
       -16.057682206809545,
       66.31167503676055
      ],
      [
       -16.00523083228827,
       66.31477425258784
      ],
      [
       -15.953794640621668,
       66.31990643812782
      ],
      [
       -15.903868990453372,
       66.3270221676282
      ],
      [
       -15.855934693086636,
       66.33605291272403
      ],
      [
       -15.810453382008658,
       66.34691170240335
      ],
      [
       -15.76786306710773,
       66.35949396058551
      ],
      [
       -15.728573916398584,
       66.37367851324608
      ],
      [
       -15.692964305880183,
       66.38932875538883
      ],
      [
       -15.661377175568012,
       66.40629396662668
      ],
      [
       -15.63411672679426,
       66.42441076270126
      ],
      [
       -15.611445492582693,
       66.4435046689627
      ],
      [
       -15.593581809312129,
       66.46339180065596
      ],
      [
       -15.580697714017745,
       66.48388063383138
      ],
      [
       -15.572917287580388,
       66.50477384982517
      ],
      [
       -15.570315459759863,
       66.52587023554591
      ]
     ]
    ]
   },
   "properties": {
    "_kind": "selection-circle",
    "_radius_m": 23959
   },
   "type": "Feature"
  }
 ],
 "properties": {
  "lat": 66.421554,
  "lng": -16.704538,
  "map": "se",
  "zoom": 9.39
 },
 "type": "FeatureCollection"
}
--- **Location:** [z9 / 66.42155 / -16.70454](https://experiments.blahonga.org/?map=se#9.39/66.4216/-16.7045) **Area:** circle r=23959 m @ 66.52587, -16.11064 ```map-report { "features": [ { "geometry": { "type": "Polygon", "coordinates": [ [ [ -15.570315459759863, 66.52587023554591 ], [ -15.572917287580388, 66.54696662126665 ], [ -15.580697714017745, 66.56785983726044 ], [ -15.593581809312129, 66.58834867043586 ], [ -15.611445492582693, 66.60823580212912 ], [ -15.63411672679426, 66.62732970839056 ], [ -15.661377175568012, 66.64544650446514 ], [ -15.692964305880183, 66.66241171570299 ], [ -15.728573916398584, 66.67806195784574 ], [ -15.76786306710773, 66.69224651050631 ], [ -15.810453382008658, 66.70482876868847 ], [ -15.855934693086636, 66.71568755836779 ], [ -15.903868990453372, 66.72471830346362 ], [ -15.953794640621668, 66.731834032964 ], [ -16.00523083228827, 66.73696621850398 ], [ -16.057682206809545, 66.74006543433127 ], [ -16.110643628776018, 66.74110183330326 ], [ -16.16360505074249, 66.74006543433127 ], [ -16.216056425263766, 66.73696621850398 ], [ -16.267492616930365, 66.731834032964 ], [ -16.317418267098663, 66.72471830346362 ], [ -16.3653525644654, 66.71568755836779 ], [ -16.41083387554338, 66.70482876868847 ], [ -16.453424190444306, 66.69224651050631 ], [ -16.49271334115345, 66.67806195784574 ], [ -16.528322951671854, 66.66241171570299 ], [ -16.55991008198402, 66.64544650446514 ], [ -16.587170530757774, 66.62732970839056 ], [ -16.609841764969342, 66.60823580212912 ], [ -16.627705448239904, 66.58834867043586 ], [ -16.64058954353429, 66.56785983726044 ], [ -16.648369969971647, 66.54696662126665 ], [ -16.65097179779217, 66.52587023554591 ], [ -16.648369969971647, 66.50477384982517 ], [ -16.64058954353429, 66.48388063383138 ], [ -16.627705448239904, 66.46339180065596 ], [ -16.609841764969342, 66.4435046689627 ], [ -16.587170530757774, 66.42441076270126 ], [ -16.559910081984025, 66.40629396662668 ], [ -16.528322951671854, 66.38932875538883 ], [ -16.49271334115345, 66.37367851324608 ], [ -16.453424190444306, 66.35949396058551 ], [ -16.41083387554338, 66.34691170240335 ], [ -16.3653525644654, 66.33605291272403 ], [ -16.317418267098663, 66.3270221676282 ], [ -16.267492616930365, 66.31990643812782 ], [ -16.216056425263766, 66.31477425258784 ], [ -16.16360505074249, 66.31167503676055 ], [ -16.110643628776018, 66.31063863778856 ], [ -16.057682206809545, 66.31167503676055 ], [ -16.00523083228827, 66.31477425258784 ], [ -15.953794640621668, 66.31990643812782 ], [ -15.903868990453372, 66.3270221676282 ], [ -15.855934693086636, 66.33605291272403 ], [ -15.810453382008658, 66.34691170240335 ], [ -15.76786306710773, 66.35949396058551 ], [ -15.728573916398584, 66.37367851324608 ], [ -15.692964305880183, 66.38932875538883 ], [ -15.661377175568012, 66.40629396662668 ], [ -15.63411672679426, 66.42441076270126 ], [ -15.611445492582693, 66.4435046689627 ], [ -15.593581809312129, 66.46339180065596 ], [ -15.580697714017745, 66.48388063383138 ], [ -15.572917287580388, 66.50477384982517 ], [ -15.570315459759863, 66.52587023554591 ] ] ] }, "properties": { "_kind": "selection-circle", "_radius_m": 23959 }, "type": "Feature" } ], "properties": { "lat": 66.421554, "lng": -16.704538, "map": "se", "zoom": 9.39 }, "type": "FeatureCollection" } ```
art commented 2026-08-05 04:26:37 +00:00
Owner
Copy link

Investigation complete — #46 is the Iceland manifestation of the #47 absorption bug, and the current live DB already satisfies the report.

Diagnosis (evidence-based):

  • Source: NOT clipped. The LMÍ landcover GeoPackage and the z13/z14 tables carry cover far north of 66.5°N; the import pipeline has no latitude clip and no mask cut.
  • Live DB per-zoom max-Y (3857): z14/z13/z11/z9 ≈ 10 033 597 m (≈66.68°N), z8 66.6832, z7 66.6831, z4/z3 ≈66.68. Nothing is cut at a straight latitude anywhere; the NE tip (Rifstangi 66.54°N) and Grímsey (66.555°N) have cover at every zoom (z11: 57 features in the report envelope; z9: 52; 6 637 features north of 66.5°N at z9).
  • Root cause: Iceland's cover got absorption for the first time in #36 (commit 336635e, min_area_pixels: 16 / min_width_pixels: 1) WITHOUT the absorb_boundary pixel floor. At coarse zoom the pixel-area thresholds are enormous (z4 ~1 531 km²/px, z8 ~6 000 km²), so every small northern polygon — the tapering NE peninsula, Grímsey — becomes a sub-threshold candidate whose only larger neighbour is the sea; it inherits water and vanishes. The "66.5°N line" is simply where Iceland narrows below screen-pixel width.
  • The report-time tables were built with the #36 code. The current live DB was rebuilt 08-04 by the #47 work whose absorb_boundary floor protects multi-pixel islands from feeding the sea — and the north is intact on that DB, verified per-zoom above and in a browser render at the z9 report location.

Status: no code change needed on this issue — the fix is the #47/#41 absorb_boundary floor, already implemented and live. Closing decision belongs to the maintainer once #55/#56 land (or now, since the live DB satisfies the report). The investigation worker hit its iteration cap before opening a PR; nothing was committed, so this issue is being left blocked rather than falsely released as untouched.

Investigation complete — #46 is the Iceland manifestation of the #47 absorption bug, and the current live DB already satisfies the report. **Diagnosis (evidence-based):** - Source: NOT clipped. The LMÍ landcover GeoPackage and the z13/z14 tables carry cover far north of 66.5°N; the import pipeline has no latitude clip and no mask cut. - Live DB per-zoom max-Y (3857): z14/z13/z11/z9 ≈ 10 033 597 m (≈66.68°N), z8 66.6832, z7 66.6831, z4/z3 ≈66.68. Nothing is cut at a straight latitude anywhere; the NE tip (Rifstangi 66.54°N) and Grímsey (66.555°N) have cover at every zoom (z11: 57 features in the report envelope; z9: 52; 6 637 features north of 66.5°N at z9). - Root cause: Iceland's cover got absorption for the first time in #36 (commit 336635e, min_area_pixels: 16 / min_width_pixels: 1) WITHOUT the absorb_boundary pixel floor. At coarse zoom the pixel-area thresholds are enormous (z4 ~1 531 km²/px, z8 ~6 000 km²), so every small northern polygon — the tapering NE peninsula, Grímsey — becomes a sub-threshold candidate whose only larger neighbour is the sea; it inherits `water` and vanishes. The "66.5°N line" is simply where Iceland narrows below screen-pixel width. - The report-time tables were built with the #36 code. The current live DB was rebuilt 08-04 by the #47 work whose absorb_boundary floor protects multi-pixel islands from feeding the sea — and the north is intact on that DB, verified per-zoom above and in a browser render at the z9 report location. **Status:** no code change needed on this issue — the fix is the #47/#41 absorb_boundary floor, already implemented and live. Closing decision belongs to the maintainer once #55/#56 land (or now, since the live DB satisfies the report). The investigation worker hit its iteration cap before opening a PR; nothing was committed, so this issue is being left blocked rather than falsely released as untouched.
art commented 2026-08-05 08:39:23 +00:00
Owner
Copy link

After all branches (except station names in Warsaw) have been merged, the tree was updated to latest main with the #47 fix in. I made sure to disable caches in the developer console, then when I saw that it still used cached tiles, I went into private window and checked that it downloaded new tiles and it did. The result are the two screenshots below.

Grimsey completely vanishes at z12, the url for that image is: https://experiments.blahonga.org/?map=is#12.71/66.54267/-17.99846

The second screenshot is around https://experiments.blahonga.org/?map=is#13.18/66.50164/-16.17706

Grimsey is literally the whole screen, it shouldn't be absorbed or generalized away anyway even if the water absorption bug was still there.

After all branches (except station names in Warsaw) have been merged, the tree was updated to latest main with the #47 fix in. I made sure to disable caches in the developer console, then when I saw that it still used cached tiles, I went into private window and checked that it downloaded new tiles and it did. The result are the two screenshots below. Grimsey completely vanishes at z12, the url for that image is: https://experiments.blahonga.org/?map=is#12.71/66.54267/-17.99846 The second screenshot is around https://experiments.blahonga.org/?map=is#13.18/66.50164/-16.17706 Grimsey is literally the whole screen, it shouldn't be absorbed or generalized away anyway even if the water absorption bug was still there.
Screenshot 2026-08-05 at 10-15-55 Iceland — ismap.png
99 KiB
Screenshot 2026-08-05 at 10-23-23 Iceland — ismap.png
115 KiB
Screenshot 2026-08-05 at 10-15-55 Iceland — ismap.png Screenshot 2026-08-05 at 10-23-23 Iceland — ismap.png
art commented 2026-08-05 09:24:32 +00:00
Owner
Copy link

Result is in #61 — #61; the review note is the PR description. In short: the LMI sea polygon is broken at the 66.5°N data cut (self-intersecting, inverted ring roles), the z12 rollup's MakeValid promotes its island loops into marine_water, and the #47 fix never touches it because the island is already water before absorption runs. The PR excludes the broken polygon and computes a valid sea from the official coastline instead. Verified in a real browser at both screenshot locations.

Result is in #61 — https://git.blahonga.org/art/ismap/pulls/61; the review note is the PR description. In short: the LMI sea polygon is broken at the 66.5°N data cut (self-intersecting, inverted ring roles), the z12 rollup's MakeValid promotes its island loops into marine_water, and the #47 fix never touches it because the island is already water before absorption runs. The PR excludes the broken polygon and computes a valid sea from the official coastline instead. Verified in a real browser at both screenshot locations.
art 2026-08-05 09:24:32 +00:00
art commented 2026-08-05 09:46:32 +00:00
Owner
Copy link

Resolved by PR #61

Resolved by PR #61
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
night/issue-62-water-flow
night/issue-47-water-coastline
No results found.
Labels
Clear labels   
claude-wip
night-shift

  
map-report
map data feedback (mapsrv)

  
map:is
map data feedback (mapsrv)

  
map:se
map data feedback (mapsrv)

  
needs-review
night-shift

No labels
claude-wip
map-report
map:is
map:se
needs-review
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
art/ismap#46
No description provided.