Finland: acceptance tests for the remaining R-checks #124

New issue

Closed

opened 2026-08-15 07:22:29 +00:00 by art · 2 comments

art commented

2026-08-15 07:22:29 +00:00

Owner

Part of the #115 plan: the mechanism (config-declared acceptance_tests:, run by the importer on every import and via -acceptance-only) landed in #119 with a representative first set. This issue tracks porting the REST of this country's R-checks into acceptance tests. The general instruction from #115: a test is a sentence citing the R-number, a SQL query whose first column is the pass/fail boolean, and a timeout from {1, 10, 100, 1000}; prefer 1s/10s, put the genuinely slow ones at 100s.

Candidates already measured/written down in docs/country-requirements.md:

R94 (issue #113): the initcap casing limit — "PASILA, TAVARA" comes back as "Pasila, Tavara"; a test could assert the known 47 multi-word names' casing rather than a blanket rule.
R70/R74: every station the source names carries its name; the 175 unnamed MTK operating points are documented as genuinely unnamed (R74's per-country count) — a test can assert the NULL-name set stays equal to the documented population.
R46/R47: waterways importance ladder (Horton shape) — Finland's network is the truncated one (R47), so a test should encode the documented gap rather than the shape.
R105: every staging table's row count is nonzero after load.
R119: row counts per zoom, no unintended empty partition, for the fi_* layers and shared partitions.

Part of the #115 plan: the mechanism (config-declared `acceptance_tests:`, run by the importer on every import and via `-acceptance-only`) landed in #119 with a representative first set. This issue tracks porting the REST of this country's R-checks into acceptance tests. The general instruction from #115: a test is a sentence citing the R-number, a SQL query whose first column is the pass/fail boolean, and a timeout from {1, 10, 100, 1000}; prefer 1s/10s, put the genuinely slow ones at 100s. Candidates already measured/written down in docs/country-requirements.md: - R94 (issue #113): the initcap casing limit — "PASILA, TAVARA" comes back as "Pasila, Tavara"; a test could assert the known 47 multi-word names' casing rather than a blanket rule. - R70/R74: every station the source names carries its name; the 175 unnamed MTK operating points are documented as genuinely unnamed (R74's per-country count) — a test can assert the NULL-name set stays equal to the documented population. - R46/R47: waterways importance ladder (Horton shape) — Finland's network is the truncated one (R47), so a test should encode the documented gap rather than the shape. - R105: every staging table's row count is nonzero after load. - R119: row counts per zoom, no unintended empty partition, for the fi_* layers and shared partitions.

art referenced this issue

2026-08-15 07:23:15 +00:00

#115: Formalized acceptance tests. #119

art referenced this issue

2026-08-15 07:23:27 +00:00

Formalized acceptance tests. #115