Poland's two absent layers were ruled out against the fetched class list, not BDOT10k's catalogue #85

New issue

Closed

opened 2026-08-09 10:35:59 +00:00 by art-bot · 1 comment

art-bot commented

2026-08-09 10:35:59 +00:00

Collaborator

Found auditing every country against docs/country-requirements.md (#77). Flags R6 — check the provider's full class catalogue before declaring a class absent.

Poland is missing two shared layers, and both absences are properly documented (R11 is satisfied — this is not that bug). The problem is what they are documented against.

`water_points`

conf/plmap.yaml says: "None of the BDOT10k classes we fetch carries waterfalls or springs."

That is a statement about BDOT10K_CLASSES in the Makefile, not about BDOT10k. The other three countries all have this layer: Iceland 8,557 rows, Sweden 16,069, Finland 178,296.

`ferries`

docs/country-poland.md says: "If Poland's przeprawy promowe are wanted, the first job is finding which BDOT10k class carries them — it is not one of the four SK*/SW* classes fetched today."

The doc names the job and does not do it. Poland has real ferry crossings on the Vistula and at Świnoujście.

Why this is one issue and why it matters

This is the exact shape of the Warsaw metro finding in #64: metro was declared to have no machine-readable source after checking GTFS feeds, city APIs and the fetched class list — and BDOT10k's OIKM_P class, carrying 258 metro entrances, had been in the national database the whole time. The fetch list simply never named it.

Two layers are currently absent from Poland on the same reasoning that was wrong once already.

The fix

Read GUGiK's published BDOT10k feature-class catalogue — the whole thing, not BDOT10K_CLASSES — and answer for each layer: which class carries it, or is it genuinely absent from the product. Then either widen the fetch list or write the negative answer into docs/country-poland.md citing the catalogue rather than the fetch config.

Note R9 if the fetch list widens: Poland's markers are named after the class set they extracted, so adding a class must invalidate them rather than being satisfied from disk.

Acceptance

docs/country-poland.md states, for water_points and ferries, the BDOT10k class that carries them or the catalogue evidence that none does.

Found auditing every country against `docs/country-requirements.md` (#77). Flags **R6** — check the provider's full class catalogue before declaring a class absent. Poland is missing two shared layers, and both absences are properly documented (**R11** is satisfied — this is not that bug). The problem is what they are documented *against*. ## `water_points` `conf/plmap.yaml` says: *"None of the BDOT10k classes **we fetch** carries waterfalls or springs."* That is a statement about `BDOT10K_CLASSES` in the Makefile, not about BDOT10k. The other three countries all have this layer: Iceland 8,557 rows, Sweden 16,069, Finland 178,296. ## `ferries` `docs/country-poland.md` says: *"If Poland's przeprawy promowe are wanted, the first job is finding which BDOT10k class carries them — it is not one of the four SK\*/SW\* classes fetched today."* The doc names the job and does not do it. Poland has real ferry crossings on the Vistula and at Świnoujście. ## Why this is one issue and why it matters This is the exact shape of the Warsaw metro finding in #64: metro was declared to have no machine-readable source after checking GTFS feeds, city APIs and the fetched class list — and BDOT10k's `OIKM_P` class, carrying 258 metro entrances, had been in the national database the whole time. The fetch list simply never named it. Two layers are currently absent from Poland on the same reasoning that was wrong once already. ## The fix Read GUGiK's published BDOT10k feature-class catalogue — the whole thing, not `BDOT10K_CLASSES` — and answer for each layer: which class carries it, or is it genuinely absent from the product. Then either widen the fetch list or write the negative answer into `docs/country-poland.md` citing the catalogue rather than the fetch config. Note **R9** if the fetch list widens: Poland's markers are named after the class set they extracted, so adding a class must invalidate them rather than being satisfied from disk. ## Acceptance `docs/country-poland.md` states, for `water_points` and `ferries`, the BDOT10k class that carries them or the catalogue evidence that none does.

art-bot referenced this issue

2026-08-09 10:40:32 +00:00

#77: write down what a country has to look like, and audit the four we have #87

art-bot was assigned by art

2026-08-09 10:48:49 +00:00