Poland: acceptance tests for the remaining R-checks #123

New issue

Closed

opened 2026-08-15 07:22:29 +00:00 by art · 1 comment

art commented

2026-08-15 07:22:29 +00:00

Owner

Part of the #115 plan: the mechanism (config-declared acceptance_tests:, run by the importer on every import and via -acceptance-only) landed in #119 with a representative first set. This issue tracks porting the REST of this country's R-checks into acceptance tests. The general instruction from #115: a test is a sentence citing the R-number, a SQL query whose first column is the pass/fail boolean, and a timeout from {1, 10, 100, 1000}; prefer 1s/10s, put the genuinely slow ones at 100s.

Candidates already measured/written down in docs/country-requirements.md:

R58 (issue #43): the BDOT10k Baltic-as-lake mislabel — flag water_bodies polygons that are order-of-magnitude area outliers for their class and cross-check against the mask's seaward edge. This is the standing data bug and the natural acceptance test for it.
R63: SELECT count(*) FROM map_roads_14_pl WHERE ref ~ '[;,]' = 0 (the delimited multi-value ref regression, issue #39).
R105: every staging table's row count is nonzero after load.
R43: the class-mapping CASE branches and the WHERE IN list stay in sync — checkable as a query-comment review rather than SQL, but the "no bare ELSE on mixed sources" property is the review surface.
R119: row counts per zoom, no unintended empty partition, for the pl_* layers and shared partitions.

Part of the #115 plan: the mechanism (config-declared `acceptance_tests:`, run by the importer on every import and via `-acceptance-only`) landed in #119 with a representative first set. This issue tracks porting the REST of this country's R-checks into acceptance tests. The general instruction from #115: a test is a sentence citing the R-number, a SQL query whose first column is the pass/fail boolean, and a timeout from {1, 10, 100, 1000}; prefer 1s/10s, put the genuinely slow ones at 100s. Candidates already measured/written down in docs/country-requirements.md: - R58 (issue #43): the BDOT10k Baltic-as-lake mislabel — flag water_bodies polygons that are order-of-magnitude area outliers for their class and cross-check against the mask's seaward edge. This is the standing data bug and the natural acceptance test for it. - R63: `SELECT count(*) FROM map_roads_14_pl WHERE ref ~ '[;,]'` = 0 (the delimited multi-value ref regression, issue #39). - R105: every staging table's row count is nonzero after load. - R43: the class-mapping CASE branches and the WHERE IN list stay in sync — checkable as a query-comment review rather than SQL, but the "no bare ELSE on mixed sources" property is the review surface. - R119: row counts per zoom, no unintended empty partition, for the pl_* layers and shared partitions.

art referenced this issue

2026-08-15 07:23:15 +00:00

#115: Formalized acceptance tests. #119

art referenced this issue

2026-08-15 07:23:27 +00:00

Formalized acceptance tests. #115